andi-huber commented on code in PR #1044:
URL: https://github.com/apache/isis/pull/1044#discussion_r938422046
##########
extensions/core/commandlog/applib/src/main/java/org/apache/isis/extensions/commandlog/applib/subscriber/CommandSubscriberForCommandLog.java:
##########
@@ -47,14 +48,14 @@
public class CommandSubscriberForCommandLog implements CommandSubscriber {
final CommandLogEntryRepository<? extends CommandLogEntry>
commandLogEntryRepository;
+ final IsisConfiguration isisConfiguration;
@Override
public void onCompleted(final Command command) {
- // TODO: JPA does not yet support lifecycle listeners, so always would
be false.
-// if(!command.isSystemStateChanged()) {
-// return;
-// }
+ if
(isisConfiguration.getExtensions().getCommandLog().getPublishPolicy().isOnlyIfSystemChanged()
&& !command.isSystemStateChanged()) {
Review Comment:
TODO this logic seems wrong, at least I'm confused reading this, maybe amend
with comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
