[ 
https://issues.apache.org/jira/browse/JCR-741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475647
 ] 

Julian Reschke commented on JCR-741:
------------------------------------

(1) Done earlier.

(2) I just spent more time on this, and the key problem seems to be that 
JCR2SPI does not use RepositoryService.getPropertyDefinition() at all. Changing 
WorkspaceItemStateFactory.createPropertyState(...) so that the property 
definition is always fetched from the repository service fixes the problem, 
because it avoids having to ask the EffectiveNodeType at all. Now this is 
probably a problem performance-wise -- wouldn't it make sense to add 
getDefinition to ItemInfo on SPI, so the additional roundtrip is not necessary?



> Handling of multiple residual prop defs in EffectiveNodeTypeImpl
> ----------------------------------------------------------------
>
>                 Key: JCR-741
>                 URL: https://issues.apache.org/jira/browse/JCR-741
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: SPI
>            Reporter: Julian Reschke
>         Assigned To: Julian Reschke
>            Priority: Minor
>
> org.apache.jackrabbit.jcr2spi.nodetype.EffectiveNodeTypeImpl currently 
> rejects multiple residual property definitions, if they do not differ in 
> getMultiple(). In fact, it should accept all combinations, so differing 
> values for getOnParentVersionAction and other aspects should be accepted as 
> well.
> See JSR 170, 6.7.8:
> "For purposes of the above, the notion of two definitions having the same 
> name does not apply to two residual definitions. Two (or more) residual 
> property or child node definitions with differing subattributes must be 
> permitted to co-exist in the same effective node type. They are interpreted 
> as disjunctive (ORed) options."

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to