Hi, [Branching the general issue from Jira]
On Jan 22, 2008 12:54 PM, angela (JIRA) <[EMAIL PROTECTED]> wrote: > but i expect that we have a minimal response time to give everybody > the time to look at a patch. apart from that i expect that patches and > suggestions are really looked at, before they are commited. -1 You're proposing a switch from CTR to RTC. There are many cases where having a patch reviewed is good, and I think we are already doing a good job of evaluating case-by-case whether such a review is needed. A good percentage of our issues go through a patch/review/commit cycle even if everyone involved could just commit the changes directly. However, there are many cases where a fix is obvious and there is no real need for a review. It should be OK to just commit such changes (to trunk) without waiting for other opinions. We have commits notifications for reviewing such changes. The decision whether to wait for review or just go ahead and commit is of course a judgment call and people make mistakes like I did with JCR-1331, but such mistakes are easily fixed by reverting the changes. I think we have at most one such revert per month on average, so I don't think this is a problem. BR, Jukka Zitting
