Hi,

On Jan 22, 2008 3:07 PM, Angela Schreiber <[EMAIL PROTECTED]> wrote:
> > -1 You're proposing a switch from CTR to RTC.
>
> i'm not proposing this. you are mistaken.

ACK, understood. Your original comment seemed like a general
observation about all changes.

> but i expect that we are careful regarding code
> that is more than an internal detail. and that
> we don't make changes forth and back....

+1 Agreed.

> and in this case waiting a couple of days would
> not have done any harm.

You're right. However, since the JCR-1331 change was relatively small
and I was quite convinced that it was the right thing to do I rather
made the change right away instead of waiting and introducing another
"context switch" a few days later.

That was a mistake but I don't think it's that big a deal, since
there's no harm in reverting a change if people object or want more
time for review.

I think you were perfectly right in calling for the changes to be
reverted, but I don't see the issue as a symptom of a more widespread
hastiness. IMHO our current workflow with voluntary reviews works
pretty well.

BR,

Jukka Zitting

Reply via email to