[ 
https://issues.apache.org/jira/browse/JCR-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563919#action_12563919
 ] 

Jukka Zitting commented on JCR-1306:
------------------------------------

Unless there's overwhelming reason not to do so, I'd rather get rid of all but 
one repository.xml file.

As for having an example configuration file, IMHO it's better to put up a 
configuration page on the web site and, if needed, point directly to the 
"official" one in o.a.j.core.

> Reduce number of different repository.xml present with jackrabbit-core
> ----------------------------------------------------------------------
>
>                 Key: JCR-1306
>                 URL: https://issues.apache.org/jira/browse/JCR-1306
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: config
>            Reporter: angela
>            Priority: Minor
>
> while taking a look at the repository configuration and the related 
> test-cases, i saw that there are quite some repository.xml files around... 
> which i think is a bit confusion and probably hard to maintain once we make
> changes to the config.
> i would to suggest to consolidate that and - if possible - get rid of some of 
> them.
> if we can't i would suggest to put some comment in every of the different 
> configuration files indicating
> what they are used for.
> from what i've seen so far (still missing complete overview)
> 1) 
> http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/config/repository.xml
>     Current comment: <!-- Example Repository Configuration File -->
>     Usage: ??
> 2) 
> http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/test-repository.xml
>    current comment: -  
>    Used as repository configuration in 
> org.apache.jackrabbit.core.TestRepository.java
>    
> 3) 
> http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/repository.xml
>   
>    current comment: <!-- Example Repository Configuration File -->
>    Used by org.apache.jackrabbit.core.config.RepositoryConfigTest.java in 
> order to create another repository.xml 
>    under target/test-repository.xml. a bit confusing given the fact, that a 
> test-repository.xml exists as well. I would
>    suggest to rename the REPOSITORY_XML constant in RepositoryConfigTest.
> 4) 
> http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/repository/repository.xml
>    current comment: <!-- Example Repository Configuration File -->
>    Usage: i assume, that is the one referenced in 
> test/resources/repositoryStubImpl.properties
> 5) 
> http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/resources/org/apache/jackrabbit/core/config/repository.xml
>    current comment: <!-- Example Repository Configuration File -->
>    Usage: ?? 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to