[
https://issues.apache.org/jira/browse/JCR-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578381#action_12578381
]
angela commented on JCR-1306:
-----------------------------
> I agree with Jukka in that we should get rid of all config files that don't
> have a sound reason to stay
> where they are.
so do i.
> Regarding to Stefan's comment, I think that there could be a new directory in
> svn called examples
> or something like that, where we can put different configuration examples.
i'm less convinced about this one... in other words: i wouldn't want (wont) to
be the one, that runs after
config changes and makes sure those examples are always up to date.
i tried to reduce to above list of repository.xml and was able to get rid of
the following with
moderate to no effort:
1) -> removed without consequences to build process
2) -> modify line 45 in TestRepository.java
5) -> removed without consequences to build process
up to now nobody spoke up for 2) and 5).
unless somebody objects, i will remove those.
regarding 1): i would prefer to remove it, since its not used while building
the source. is anybody volunteering to make sure, that is is up to date?
> Reduce number of different repository.xml present with jackrabbit-core
> ----------------------------------------------------------------------
>
> Key: JCR-1306
> URL: https://issues.apache.org/jira/browse/JCR-1306
> Project: Jackrabbit
> Issue Type: Improvement
> Components: config
> Reporter: angela
> Priority: Minor
>
> while taking a look at the repository configuration and the related
> test-cases, i saw that there are quite some repository.xml files around...
> which i think is a bit confusion and probably hard to maintain once we make
> changes to the config.
> i would to suggest to consolidate that and - if possible - get rid of some of
> them.
> if we can't i would suggest to put some comment in every of the different
> configuration files indicating
> what they are used for.
> from what i've seen so far (still missing complete overview)
> 1)
> http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/config/repository.xml
> Current comment: <!-- Example Repository Configuration File -->
> Usage: ??
> 2)
> http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/test-repository.xml
> current comment: -
> Used as repository configuration in
> org.apache.jackrabbit.core.TestRepository.java
>
> 3)
> http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/repository.xml
>
> current comment: <!-- Example Repository Configuration File -->
> Used by org.apache.jackrabbit.core.config.RepositoryConfigTest.java in
> order to create another repository.xml
> under target/test-repository.xml. a bit confusing given the fact, that a
> test-repository.xml exists as well. I would
> suggest to rename the REPOSITORY_XML constant in RepositoryConfigTest.
> 4)
> http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/repository/repository.xml
> current comment: <!-- Example Repository Configuration File -->
> Usage: i assume, that is the one referenced in
> test/resources/repositoryStubImpl.properties
> 5)
> http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/resources/org/apache/jackrabbit/core/config/repository.xml
> current comment: <!-- Example Repository Configuration File -->
> Usage: ??
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
