[jira] Created: (JCR-1398) [PATCH] ClassDescriptor.hasIdField uses faulty logic

[Dave Brosius (JIRA)]

[PATCH] ClassDescriptor.hasIdField uses faulty logic
----------------------------------------------------

                 Key: JCR-1398
                 URL: https://issues.apache.org/jira/browse/JCR-1398
             Project: Jackrabbit
          Issue Type: Bug
          Components: jackrabbit-ocm
    Affects Versions: 1.4
            Reporter: Dave Brosius
            Priority: Minor
             Fix For: 1.4.1
         Attachments: classdescriptor_isid.patch

hasIdField tries to compare a FieldDescriptor to an empty string, which doesn't 
make sense, here:

     public boolean hasIdField() {
        return (this.idFieldDescriptor != null && ! 
this.idFieldDescriptor.equals(""));
     }


i'm assuming it should be

       return (this.idFieldDescriptor != null && this.idFieldDescriptor.isId());

patch does this



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.