[
https://issues.apache.org/jira/browse/JCR-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christophe Lombart resolved JCR-1398.
-------------------------------------
Resolution: Fixed
Fix Version/s: (was: 1.4.1)
1.5
Patch applied - Thanks
> [PATCH] ClassDescriptor.hasIdField uses faulty logic
> ----------------------------------------------------
>
> Key: JCR-1398
> URL: https://issues.apache.org/jira/browse/JCR-1398
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-ocm
> Affects Versions: 1.4
> Reporter: Dave Brosius
> Assignee: Christophe Lombart
> Priority: Minor
> Fix For: 1.5
>
> Attachments: classdescriptor_isid.patch
>
>
> hasIdField tries to compare a FieldDescriptor to an empty string, which
> doesn't make sense, here:
> public boolean hasIdField() {
> return (this.idFieldDescriptor != null && !
> this.idFieldDescriptor.equals(""));
> }
> i'm assuming it should be
> return (this.idFieldDescriptor != null &&
> this.idFieldDescriptor.isId());
> patch does this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
