Julian Reschke wrote:
- change the return value of getChildInfos so that size information is
there (Iterator -> RangeIterator or Collection)
didn't we have that discussion before? (JCR-1239)
since jcr2spi will still have to process the Iterator in order
to populate the hierarchy in order to properly respond to
'hasNode' or 'hasNodes' or 'getNodes', i don't see the
benefit of the Iterator over Array.
And Collection is wrong from my point of view.
- change the values so that we can return ItemInfos instead of or in
addition to ChildInfos (either by refactoring the class hierarchy so
ItemInfo extends ChildInfo,
see answer to the corresponding suggestion-mail.
or by just allowing both types in the Iterator).
oh no! i would oppose to that.
regards
angela
BR, Julian
Marcel Reutegger wrote:
Julian Reschke wrote:
Why don't we change things so that ItemInfo *extends* ChildInfo, so
that SPI implementations can return NodeInfos as well? JCR2SPI could
then use that to update its internal cache, avoiding to refetch the
NodeInfos.
I'd rather keep it the way it is right now, but introduce accessors to
PropertyInfos and ChildInfos on the NodeInfo. As mentioned in a
previous mail, an implementation would then provide the complete
Property/ChildInfos or null (if it does not want to batch the
information or it thinks it is too expensive to do so). I think this
also nicely aligns with our experience with the bundle persistence
manager. the overhead of loading property states is usually quickly
amortized because some of the properties of a node are read in most
cases.
regards
marcel
Index: src/main/java/org/apache/jackrabbit/spi/NodeInfo.java
===================================================================
--- src/main/java/org/apache/jackrabbit/spi/NodeInfo.java (revision
617369)
+++ src/main/java/org/apache/jackrabbit/spi/NodeInfo.java (working
copy)
@@ -72,4 +72,31 @@
* @see PropertyInfo#getId()
*/
public Iterator getPropertyIds();
+
+ /**
+ * Returns the property infos of this node info or
<code>null</code> if none
+ * are provided. If a non-null value is returned an
implementation must
+ * return the complete list of property infos. If an
implemetation returns
+ * <code>null</code> a client must use [EMAIL PROTECTED]
#getPropertyIds()} in
+ * conjunction with
+ * [EMAIL PROTECTED] RepositoryService#getPropertyInfo(SessionInfo,
PropertyId)} to
+ * retrieve property infos.
+ *
+ * @return Returns the property infos of this node info or
<code>null</code>
+ * if none are provided.
+ */
+ public PropertyInfo[] getPropertyInfos();
+
+ /**
+ * Returns the child infos of this node info or <code>null</code>
if none
+ * are provided. If a non-null value is returned an
implementation must
+ * return the complete list of child infos. If an implementation
returns
+ * <code>null</code> a client must use
+ * [EMAIL PROTECTED] RepositoryService#getChildInfos(SessionInfo, NodeId)}
to retrieve
+ * the child infos for this node info.
+ *
+ * @return the child infos of this node info or <code>null</code>
if none
+ * are provided.
+ */
+ public ChildInfo[] getChildInfos();
}
