[
https://issues.apache.org/jira/browse/JCR-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573844#action_12573844
]
Thomas Mueller commented on JCR-1388:
-------------------------------------
Hi,
Your new patch is better, but there are still a few issues:
You still have tabs in the source code.
DbResources and DatabaseHelper still don't have correct license headers.
There is still a catch (Exception e) {}.
There are still some cases where "} else {" and so on is not on the same line.
Please format the source code. In Eclipse, use [Source] [Format]. I suggest you
review the Sun coding guidelines at http://java.sun.com/docs/codeconv/
Javadoc comments are still not correct. getLastModified doesn't have a Javadoc
comment. @return tag is still not used.
Variables are still declared at the start of the method in
getDatabaseResources(). Please declare them when / just before using them
DbInputStream.mark and reset are synchronized, but nothing else in this class,
why?
The SQL statement remark "// SELECT ID, DATA FROM DATASTORE WHERE ID = ?" was
there to simplify reading the code (so you don't have to switch to another file
to understand it).
Please add it where selectDataSQL is used.
About the method finalize(): I wouldn't use it. It slows down creating objects.
If the wrapped InputStream and resource need finalize(), it is already
implemented there.
About the test cases:
- ".classpath" doesn't exist in all systems (RandomInputStream is better).
- Don't use System.out.println, use a logger.
- Add the test to the TestAll method.
- You have again used return(..) instead of return ..
- The Javadoc comment is empty
Regards,
Thomas
> Jackrabbit does not allow concurrent reads to the data store if
> copyWhenReading=false
> -------------------------------------------------------------------------------------
>
> Key: JCR-1388
> URL: https://issues.apache.org/jira/browse/JCR-1388
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core
> Affects Versions: 1.4
> Environment: WinXP x64, Eclipse, remote SQL Server 2005
> Reporter: Esteban Franqueiro
> Attachments: JCR-1388-datastore-concurrent-reads.2.patch,
> JCR-1388-datastore-concurrent-reads.patch, TestTwoGetStreams.java
>
>
> Jackrabbit does not allow concurrent reads to the data store if
> copyWhenReading=false, even if maxConnections>1.
> See JCR-1184 for a test for this problem (run it with copyWhenReading=false).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
