[ 
https://issues.apache.org/jira/browse/JCR-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Esteban Franqueiro updated JCR-1388:
------------------------------------

    Attachment: JCR-1388-datastore-concurrent-reads.9.patch

> As I wrote before, I suggest you use Checkstyle so that you can find such 
> problems yourself. 

I'm using it, but I missed those.

> What is the reason for the following code?
>  ...
> Why do you close i1 and i2 twice? Why do you check for null?

Oops my mistake. Fixed that. I left the try/catch calls, so that it logs the 
exception. Should I re-throw it?


> Jackrabbit does not allow concurrent reads to the data store if 
> copyWhenReading=false
> -------------------------------------------------------------------------------------
>
>                 Key: JCR-1388
>                 URL: https://issues.apache.org/jira/browse/JCR-1388
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>    Affects Versions: 1.4
>         Environment: WinXP x64, Eclipse, remote SQL Server 2005
>            Reporter: Esteban Franqueiro
>         Attachments: JCR-1388-datastore-concurrent-reads.2.patch, 
> JCR-1388-datastore-concurrent-reads.4.patch, 
> JCR-1388-datastore-concurrent-reads.8.patch, 
> JCR-1388-datastore-concurrent-reads.9.patch, 
> JCR-1388-datastore-concurrent-reads.patch, TestTwoGetStreams.java
>
>
> Jackrabbit does not allow concurrent reads to the data store if 
> copyWhenReading=false, even if maxConnections>1.
> See JCR-1184 for a test for this problem (run it with copyWhenReading=false).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to