[ 
https://issues.apache.org/jira/browse/JCR-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575049#action_12575049
 ] 

Jukka Zitting commented on JCR-1452:
------------------------------------

> Of course it makes sense to scale them down to make them runnable. A test 
> case with
> a 50 KB blob goes through quite a lot of code, code that would otherwise not 
> be tested.

Sure, but that's a completely different test case than the "blob that is too 
large to fit in memory" one.

I'm not against having also the 50kB test case, but there should be some reason 
for it to exist. The TCK already has a number of binary property test cases, so 
do we need another one specific to Jackrabbit? What's the added value of having 
and running that test case?

IMHO we shouldn't just test things because we can. There should always be some 
known target for a test case, and optimally no two tests should target the same 
thing.

> Make use of jackrabbit.test.scale in test cases
> -----------------------------------------------
>
>                 Key: JCR-1452
>                 URL: https://issues.apache.org/jira/browse/JCR-1452
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Marcel Reutegger
>            Priority: Minor
>             Fix For: 1.5
>
>
> There are already a number of longer running test cases in jackrabbit-core, 
> but they are all disabled because they otherwise make building 
> jackrabbit-core a very long task.
> Those tests should make use of the jackrabbit.test.scale property and per 
> default (scale = 1) run within a short time.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to