[
https://issues.apache.org/jira/browse/JCR-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705522#action_12705522
]
Michael Dürig commented on JCR-2096:
------------------------------------
> enabling the -tests jar to be built from spi2jcr.
Sure but I think the tests don't really belong there. While each SPI
implementation might want to run theses tests, they still belong to jcr2spi.
Moving them to jcr-tests sounds good to me. It does however further blur the
separation between the core an SPI based implementations. From this perspective
it would be better to have a new spi-tests module which would introduce a
further module however. I dont have strong feeling for either of both solutions.
> Move jcr2spi tests to spi2jcr
> -----------------------------
>
> Key: JCR-2096
> URL: https://issues.apache.org/jira/browse/JCR-2096
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-jcr2spi, jackrabbit-spi2jcr, test
> Reporter: Jukka Zitting
>
> Currently we have a number of test cases included in the jcr2spi component,
> but they aren't being run in there (surefire plugin is disabled). Instead,
> the tests are packaged into a -tests jar that is then used in the spi2jcr
> component to run them.
> The downside of this setup are 1) extra complexity and 2) the fact that a
> -Dmaven.test.skip=true build will not work with a clean Maven repository as
> the jcr2spi -tests jar is not being built for spi2jcr.
> How about if we simply moved the tests to the spi2jcr component where they
> are being used?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
