[
https://issues.apache.org/jira/browse/JCR-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706036#action_12706036
]
angela commented on JCR-2096:
-----------------------------
> How about if we simply moved the tests to the spi2jcr component where they
> are being used?
this is a misunderstanding. the tests are not only used in the spi2jcr
component but may be used together with
any spi implementation.
second: they belong to jcr2spi (or to jackrabbit-jcr-test) since they are
testing JCR API or the behaviour of the
JCR implementation. they do not test the correctness of an SPI implementation.
therefore i agree with michael that they don't belong to the spi2xyz
implementation.
i already opened an issue asking for moving the generic tests from jcr2spi to
jcr-tests (issue JCR-1874)... thus i think we can close this one as won't fix
or invalid. is that ok for you jukka?
> Move jcr2spi tests to spi2jcr
> -----------------------------
>
> Key: JCR-2096
> URL: https://issues.apache.org/jira/browse/JCR-2096
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-jcr2spi, jackrabbit-spi2jcr, test
> Reporter: Jukka Zitting
>
> Currently we have a number of test cases included in the jcr2spi component,
> but they aren't being run in there (surefire plugin is disabled). Instead,
> the tests are packaged into a -tests jar that is then used in the spi2jcr
> component to run them.
> The downside of this setup are 1) extra complexity and 2) the fact that a
> -Dmaven.test.skip=true build will not work with a clean Maven repository as
> the jcr2spi -tests jar is not being built for spi2jcr.
> How about if we simply moved the tests to the spi2jcr component where they
> are being used?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
