not really criticizing this particular commit since I already reviewed it and said it looks good ;) but I just noticed that we should now rather use StringBuilder (available in Java 5) instead of synchronized StringBuffer. This is similar to using ArrayList when possible rather than Vector...
regards marcel On Wed, Jul 8, 2009 at 13:28, <[email protected]> wrote: > Author: mduerig > Date: Wed Jul 8 11:28:03 2009 > New Revision: 792102 > > URL: http://svn.apache.org/viewvc?rev=792102&view=rev > Log: > JCR-2194: EventImpl should implement toString > > Modified: > > jackrabbit/trunk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/EventImpl.java > > Modified: > jackrabbit/trunk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/EventImpl.java > URL: > http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/EventImpl.java?rev=792102&r1=792101&r2=792102&view=diff > ============================================================================== > --- > jackrabbit/trunk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/EventImpl.java > (original) > +++ > jackrabbit/trunk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/EventImpl.java > Wed Jul 8 11:28:03 2009 > @@ -181,4 +181,19 @@ > return timestamp; > } > } > + > + public String toString() { > + return new StringBuffer(getClass().getName()) > + .append("[") > + .append("eventTypes: ").append(type).append(", ") > + .append("absPath: ").append(path).append(", ") > + .append("itemId: ").append(itemId).append(", ") > + .append("parentId: ").append(parentId).append(", ") > + .append("primaryNodeTypeName: > ").append(primaryNodeTypeName).append(", ") > + .append("mixinTypeNames: ").append(mixinTypeNames).append(", ") > + .append("userId").append(userId) > + .append("]") > + .toString(); > + } > + > } > > >
