[ 
https://issues.apache.org/jira/browse/JCR-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750464#action_12750464
 ] 

Thomas Mueller commented on JCR-1865:
-------------------------------------

> Why do we need to modify JackrabbitSession for this

To ensure the session is authorized. Otherwise how do you ensure only 
authorized users use the facility?

> I'd just put all the management interfaces in o.a.j.api.management

Ok, I don't care.

> I'd drop the DataStore part of the interface and method names

It's for the data store, so I think it makes sense to keep the name. But I 
don't care that much. 

> Do we really need the MarkEventListener mechanism

Yes, we do, it's important. However I could document that it may return null if 
not supported by the given implementation.

> The sleepBetweenNodes property seems really implementation specific

You are right, it's not that important. I will remove it.

> do we then need to expose a close() method on the garbage collector?

Yes. The current implementation can add an observation listener, and this needs 
to be removed.






> Add the Data Store to the Jackrabbit API
> ----------------------------------------
>
>                 Key: JCR-1865
>                 URL: https://issues.apache.org/jira/browse/JCR-1865
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Thomas Mueller
>            Assignee: Thomas Mueller
>            Priority: Minor
>         Attachments: api.patch, api_2.patch, core.patch, core_2.patch
>
>
> Currently, the garbage collection is not part of the Jackrabbit API. However, 
> the data store garbage collection must be used once in a while if the data 
> store is enabled. I propose to add the required interfaces to the Jackrabbit 
> API. This will also allow to call garbage collection using RMI.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to