[ 
https://issues.apache.org/jira/browse/JCR-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750611#action_12750611
 ] 

Thomas Mueller commented on JCR-1865:
-------------------------------------

Could you provide code examples, and all interfaces required for your solution? 
How would a user get the DataStoreGarbageCollector object in a _standalone_ 
application using the JCR 2.0 API (not within an app server, no JNDI and such), 
and could you explain how this would be secure (so that only people with access 
right can get the object)? And what would be the advantage over my proposal?

> the standard RMI or JMXMP access controls

Access control should stay within the Jackrabbit API I believe. Why would we 
have to 'outsource' access control to such APIs?

> The API as proposed only tells what the collector is currently doing not how 
> much work still remains. Is that enough?

Yes, this is enough.

> Does the MarkEventListener interface need to extend EventListener?

We can still discuss the details about this, let's first solve the 
getDataStoreGarbageCollector problem.

> I now see your point about the close() method, but couldn't the sweep() 
> method already release any reserved resources?

No, because the user may not want to call sweep(). If multiple repositories 
share the same data store, garbage collection would work like this:

rep1gc.mark()
rep2gc.mark()
rep3gc.mark()
rep1gc.sweep()

(rep2gc.sweep() and rep3gc.sweep() must not be called, otherwise used objects 
may be deleted).



> Add the Data Store to the Jackrabbit API
> ----------------------------------------
>
>                 Key: JCR-1865
>                 URL: https://issues.apache.org/jira/browse/JCR-1865
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Thomas Mueller
>            Assignee: Thomas Mueller
>            Priority: Minor
>         Attachments: api.patch, api_2.patch, core.patch, core_2.patch
>
>
> Currently, the garbage collection is not part of the Jackrabbit API. However, 
> the data store garbage collection must be used once in a while if the data 
> store is enabled. I propose to add the required interfaces to the Jackrabbit 
> API. This will also allow to call garbage collection using RMI.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to