On 2011-11-29 19:24, Michael Dürig wrote:
On 29.11.11 17:46, Julian Reschke wrote:
Internally, SET can always be implemented as atomic variant of
REMOVE-then-ADD.
In general yes. However for the Jackrabbit Microkernel use case this
becomes troublesome wrt. observation.
The diff format makes no promises about the observable events, so I
wouldn't worry about that.
What I'm worrying about is that when the format doesn't allow us to
implement JCR observation, we won't use it but rather a derivative of
it.
Could you elaborate what the problem is?
The Microkernel uses the JSOP diff format to report changes in the
repository (see Microkernel.getJournal() [1]. The upper layers use this
change log to create JCR observation events. So for properties, there
needs to be a way to tell 'remove' followed by 'add' apart from 'set' in
order to create the correct JCR events.
Understood. But I don't think the proposed change does any harm here.
Best regards, Julian
