[
https://issues.apache.org/jira/browse/JCR-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15471160#comment-15471160
]
ASF GitHub Bot commented on JCR-4008:
-------------------------------------
GitHub user woonsan opened a pull request:
https://github.com/apache/jackrabbit/pull/42
JCR-4008: restoring #testDeleteRecord() tests by disabling async uploading.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/woonsan/jackrabbit bugfix/JCR-4008-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jackrabbit/pull/42.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #42
----
commit 43af6b1fc1049d718df60ec0330e41b19a9c68d9
Author: Woonsan Ko <[email protected]>
Date: 2016-09-07T17:02:51Z
JCR-4008: restoring #testDeleteRecord() tests by disabling async uploading.
----
> Restore TestCachingFDS.testDeleteRecord() to fix it with disabling
> AsyncUpload in unit tests
> --------------------------------------------------------------------------------------------
>
> Key: JCR-4008
> URL: https://issues.apache.org/jira/browse/JCR-4008
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Affects Versions: 2.13.2
> Reporter: Woonsan Ko
> Fix For: 2.13.4
>
>
> The test used to fail occasionally before the test method was commented out
> by JCR-4006:
> {noformat}
> junit.framework.AssertionFailedError: rec2 should be null
> at junit.framework.Assert.fail(Assert.java:50)
> at junit.framework.Assert.assertTrue(Assert.java:20)
> at junit.framework.Assert.assertNull(Assert.java:237)
> at
> org.apache.jackrabbit.core.data.TestCaseBase.doDeleteRecordTest(TestCaseBase.java:327)
> at
> org.apache.jackrabbit.core.data.TestCaseBase.testDeleteRecord(TestCaseBase.java:192)
> {noformat}
> The main reason of this error is because the underlying backend uses
> asynchronous writing threads by default, which is not working well when
> extending {{org.apache.jackrabbit.core.data.TestCaseBase}} as mentioned in
> JCR-4005.
> So, it seems better to fix it again like the following like how JCR-4005 was
> fixed:
> - Restore the commented out block ({{TestCachingFDS.testDeleteRecord()}}).
> - Provide an option to disable asynchronous writing in all the related
> backend implementations. e.g., disable it if {{asyncWritePoolSize}} is zero
> or smaller.
> - In unit tests, simply disable async writing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
