[ https://issues.apache.org/jira/browse/JCR-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15471205#comment-15471205 ]
Woonsan Ko commented on JCR-4008: --------------------------------- Hi [~amitjain], Thanks for clarification! I've closed the old pull request and posted a new one: https://github.com/apache/jackrabbit/pull/42 Please take a review. By the way, I've created another ticket for the small 'refactoring': JCR-4018. I'd like to post a separate PR to the ticket as soon as this issue gets resolved. Kind regards, Woonsan > Restore TestCachingFDS.testDeleteRecord() to fix it with disabling > AsyncUpload in unit tests > -------------------------------------------------------------------------------------------- > > Key: JCR-4008 > URL: https://issues.apache.org/jira/browse/JCR-4008 > Project: Jackrabbit Content Repository > Issue Type: Bug > Affects Versions: 2.13.2 > Reporter: Woonsan Ko > Fix For: 2.13.4 > > > The test used to fail occasionally before the test method was commented out > by JCR-4006: > {noformat} > junit.framework.AssertionFailedError: rec2 should be null > at junit.framework.Assert.fail(Assert.java:50) > at junit.framework.Assert.assertTrue(Assert.java:20) > at junit.framework.Assert.assertNull(Assert.java:237) > at > org.apache.jackrabbit.core.data.TestCaseBase.doDeleteRecordTest(TestCaseBase.java:327) > at > org.apache.jackrabbit.core.data.TestCaseBase.testDeleteRecord(TestCaseBase.java:192) > {noformat} > The main reason of this error is because the underlying backend uses > asynchronous writing threads by default, which is not working well when > extending {{org.apache.jackrabbit.core.data.TestCaseBase}} as mentioned in > JCR-4005. > So, it seems better to fix it again like the following like how JCR-4005 was > fixed: > - Restore the commented out block ({{TestCachingFDS.testDeleteRecord()}}). > - Provide an option to disable asynchronous writing in all the related > backend implementations. e.g., disable it if {{asyncWritePoolSize}} is zero > or smaller. > - In unit tests, simply disable async writing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)