[
https://issues.apache.org/jira/browse/JCR-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478308#comment-15478308
]
ASF GitHub Bot commented on JCR-4018:
-------------------------------------
GitHub user woonsan opened a pull request:
https://github.com/apache/jackrabbit/pull/43
JCR-4018: small refactoring to avoid duplicate code with introducing
AbstractBackend for consistent backend configuration/behaviors
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/woonsan/jackrabbit feature/JCR-4018
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jackrabbit/pull/43.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #43
----
commit b20ff875c433c93bc47b3cc5da114d1dd766fd28
Author: Woonsan Ko <[email protected]>
Date: 2016-09-09T21:21:34Z
JCR-4018: small refactoring to avoid duplicate code with introducing
AbstractBackend for consistent backend configuration/behaviors.
commit cf6e97265e276c6a6f5ddcde00e2c9bebb8ecd07
Author: Woonsan Ko <[email protected]>
Date: 2016-09-09T21:28:16Z
JCR-4018: remove FSBackend#createAsyncWriteExecutor() because it's already
defined in AbstractBackend.
----
> Consistent Async Upload Executor handling in Backend implementations
> --------------------------------------------------------------------
>
> Key: JCR-4018
> URL: https://issues.apache.org/jira/browse/JCR-4018
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Reporter: Woonsan Ko
> Priority: Minor
> Labels: PatchAvailable
> Fix For: 2.13.4
>
>
> There are some inconsistent configuration/behaviors regarding asynchronous
> upload executor handling.
> For example,
> - {{VFSBackend}} disables async upload based on {{asyncPoolSize}} not based
> on {{CachingDataStore#asyncUploadLimit}}.
> - {{FSBackend}} disables it based on {{CachingDataStore#asyncUploadLimit}}
> correctly as of JCR-4008.
> - {{S3Backend}} doesn't have a feature to disable async uploading yet.
> Probably it would be nicer to have {{AbstractBackend}} for all the practical
> {{Backend}} implementations to share the handling on asynchronous uploading
> features such as how to create an {{Executor}} and async executor pool size,
> etc. There are already some duplicate code regarding this in {{VFSBackend}}
> and {{FSBackend}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
