[ 
https://issues.apache.org/jira/browse/JCR-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493285#comment-15493285
 ] 

ASF GitHub Bot commented on JCR-4018:
-------------------------------------

Github user woonsan closed the pull request at:

    https://github.com/apache/jackrabbit/pull/43


> Consistent Async Upload Executor handling in Backend implementations
> --------------------------------------------------------------------
>
>                 Key: JCR-4018
>                 URL: https://issues.apache.org/jira/browse/JCR-4018
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>            Reporter: Woonsan Ko
>            Assignee: Amit Jain
>              Labels: PatchAvailable
>             Fix For: 2.13.4
>
>
> There are some inconsistent configuration/behaviors regarding asynchronous 
> upload executor handling.
> For example,
> - {{VFSBackend}} disables async upload based on {{asyncPoolSize}} not based 
> on {{CachingDataStore#asyncUploadLimit}}.
> - {{FSBackend}} disables it based on {{CachingDataStore#asyncUploadLimit}} 
> correctly as of JCR-4008.
> - {{S3Backend}} doesn't have a feature to disable async uploading yet.
> Probably it would be nicer to have {{AbstractBackend}} for all the practical 
> {{Backend}} implementations to share the handling on asynchronous uploading 
> features such as how to create an {{Executor}} and async executor pool size, 
> etc. There are already some duplicate code regarding this in {{VFSBackend}} 
> and {{FSBackend}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to