[ 
https://issues.apache.org/jira/browse/JCR-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15732707#comment-15732707
 ] 

ASF GitHub Bot commented on JCR-4077:
-------------------------------------

GitHub user woonsan opened a pull request:

    https://github.com/apache/jackrabbit/pull/49

    JCR-4077: Removing http dependency (indirect by using http-based FSO) in 
test case

    I've improved the test case, TestVFSDataStore, to avoid any http related 
dependency which is made indirectly by using HttpFileSystemConfigBuilder.
    The original intention was just to make sure the parameters passed to the 
FSO in the end. Not intended to test with http specifically.
    Also, since Jackrabbit is removing the old commons http client dependency 
(used by the old jackrabbit-webdav), I think we'd better remove http dependency 
in test case like this fix.
    Therefore, I replaced the test case to use SftpFileSystemConfigBuilder and 
sftp configuration example by default.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/woonsan/jackrabbit bugfix/JCR-4077

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jackrabbit/pull/49.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #49
    
----
commit bf241e35aa5089bc35c63f81e765b74e9707ab98
Author: Woonsan Ko <woon...@apache.org>
Date:   2016-12-08T16:45:30Z

    JCR-4077: Removing http dependency (indirect by using http-based FSO) in 
test case.

----


> disable Jackrabbit VFS Extension (?)
> ------------------------------------
>
>                 Key: JCR-4077
>                 URL: https://issues.apache.org/jira/browse/JCR-4077
>             Project: Jackrabbit Content Repository
>          Issue Type: Sub-task
>          Components: jackrabbit-vfs-ext
>    Affects Versions: 2.13.6
>            Reporter: Julian Reschke
>             Fix For: 2.14
>
>
> Switching to the new httpclient code will break jackrabbit-vfs-ext, which has 
> a dependency on the older version.
> (Suggestions about how to deal with this welcome)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to