[ 
https://issues.apache.org/jira/browse/JCRVLT-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425837#comment-16425837
 ] 

Konrad Windszus commented on JCRVLT-279:
----------------------------------------

I added a (currently failing) test case in 
https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/13. 

The fix is not that easy though, as switching to {{Archiver.DUPLICATES_FAIL}} 
leads to a lot of false positives due to the logic in 
https://github.com/apache/jackrabbit-filevault-package-maven-plugin/blob/f165aac9c02025650d01d1ee6997448c375796fe/src/main/java/org/apache/jackrabbit/filevault/maven/packaging/VaultMojo.java#L237
 which potentially adds overlapping filesets. Also in case of overlapping 
filter rules false positives may happen. Therefore another solution has to be 
found for this issue.

> Emit warning/error in case embedded file/subpackage is overwritten by 
> jcrRootSourceDirectory
> --------------------------------------------------------------------------------------------
>
>                 Key: JCRVLT-279
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-279
>             Project: Jackrabbit FileVault
>          Issue Type: Bug
>          Components: package maven plugin
>    Affects Versions: package-maven-plugin-1.0.1
>            Reporter: Konrad Windszus
>            Priority: Minor
>
> Due to errorneous project setup it may sometimes happen that the 
> {{jcrRootSourceDirectory}} inadvertently contains the to be embedded file. 
> Since the {{jcrRootSourceDirectory}} is having a higher precedence all files 
> in there overwrite previously embedded files. In that case a warning/error 
> should be emitted. The same for sub packages.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to