kwin commented on a change in pull request #46:
URL:
https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/46#discussion_r532696738
##########
File path:
src/main/java/org/apache/jackrabbit/filevault/maven/packaging/FormatDocviewXmlMojo.java
##########
@@ -109,7 +111,14 @@ public void execute() throws MojoExecutionException,
MojoFailureException {
getLog().info("Skip executing mojo 'format-xml' for incremental
builds as parameter 'enableForIncrementalBuilds' is set to 'false'");
} else {
File jcrSourceDirectory =
AbstractSourceAndMetadataPackageMojo.getFirstExistingDirectory(jcrRootSourceDirectory);
- executeInternal(jcrSourceDirectory);
+ if (jcrSourceDirectory != null) {
+ executeInternal(jcrSourceDirectory);
+ } else {
+ if (getLog().isDebugEnabled()) {
+ getLog().debug("None of the configured
jcrRootSourceDirectory directories exists, skipping: " +
Review comment:
Maybe one could check the current packaging to silently ignore this for
packaging != content-package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
