tripodsan commented on a change in pull request #163:
URL:
https://github.com/apache/jackrabbit-filevault/pull/163#discussion_r698665828
##########
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java
##########
@@ -1215,13 +1215,13 @@ public void endElement(String uri, String localName,
String qName) throws SAXExc
}
} else {
if (wspFilter.getImportMode(path) ==
ImportMode.REPLACE) {
- importInfo.onDeleted(path);
// check if child is not protected
if (child.getDefinition().isProtected()) {
log.debug("Refuse to delete protected
child node: {}", path);
- } else if
(child.getDefinition().isMandatory()) {
+ } else if (child.getDefinition().isMandatory()
&& numChildren <= JcrConstants.NUM_MANDATORY_CHILDREN) {
Review comment:
however, I think this check is not correct. you need to count the number
of child nodes that match the property definition. just having any other child
node is not enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
