tripodsan commented on a change in pull request #163:
URL: 
https://github.com/apache/jackrabbit-filevault/pull/163#discussion_r700807487



##########
File path: 
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java
##########
@@ -1247,6 +1248,21 @@ public void endElement(String uri, String localName, 
String qName) throws SAXExc
         }
     }
 
+    private int getSiblWithReqPrimType(Node child) throws RepositoryException {

Review comment:
       or:
   
   ```
   getNumChildrenWithType(Node parent, String primaryNodeType)
   ```
   
   and then check using `isNodeType()` against the required type (not the child 
type), since the child you are testing could be an super type of the one that 
is required by the CND.

##########
File path: 
vault-core/src/main/java/org/apache/jackrabbit/vault/util/JcrConstants.java
##########
@@ -231,7 +231,12 @@
      * Pseudo property jcr:score used with query results
      */
     public static final String JCR_SCORE = "jcr:score";
-
+    /**
+     * One child node is mandatory.
+     * A mandatory item is one that, if
+     * its parent node exists, must also exist.
+     */
+    public static final int NUM_MANDATORY_CHILDREN = 1;

Review comment:
       you don't need this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to