kwin commented on a change in pull request #163:
URL:
https://github.com/apache/jackrabbit-filevault/pull/163#discussion_r711728698
##########
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java
##########
@@ -1295,6 +1300,31 @@ public void endElement(String uri, String localName,
String qName) throws SAXExc
}
}
+ private int getNumChildrenWithType(Node parent, Node child) throws
RepositoryException {
+
+ int count=0;
+
+ NodeIterator iter = parent.getNodes();
+
+ EffectiveNodeType ent = EffectiveNodeType.ofNode(parent);
+ Optional<NodeDefinition> def =
ent.getApplicableChildNodeDefinition(child.getName(),
child.getPrimaryNodeType());
+
+ while (iter.hasNext()) {
+ Node sibling = iter.nextNode();
+ Optional<NodeDefinition> childDef =
ent.getApplicableChildNodeDefinition(sibling.getName(),
sibling.getPrimaryNodeType());
+ Boolean test = (def == childDef) || (def != null &&
def.equals(childDef));
+
+ /*This is not working
+ if(def.equals(childDef)) {
+ count++;
+ }*/
+
if(Arrays.equals(def.get().getRequiredPrimaryTypes(),childDef.get().getRequiredPrimaryTypes()))
{
+ count++;
+ }
Review comment:
Right, but equals() is not implemented in
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/nodetype/ItemDefinitionImpl.java
either (nor does it necessarily have to according to the JCR 2.0 spec). Feel
free to raise a PR for Oak.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
