kwin commented on a change in pull request #163:
URL:
https://github.com/apache/jackrabbit-filevault/pull/163#discussion_r747260912
##########
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java
##########
@@ -1295,6 +1298,33 @@ public void endElement(String uri, String localName,
String qName) throws SAXExc
}
}
+ private boolean hasSiblingWithSameType(Node child) throws
RepositoryException {
+
+ Node parent = child.getParent();
+
+ try {
+ EffectiveNodeType ent = EffectiveNodeType.ofNode(parent);
+ String typeName =
ent.getApplicableChildNodeDefinition(child.getName(),
child.getPrimaryNodeType()).get().getName();
Review comment:
I am not talking about line 6 which takes into account mixins and
inheritance, but about line 7 which retrieves the applicable mixin. IMHO this
needs to parameterized with name, primary and mixin types otherwise the wrong
applicable child node definition might be returned (the child node might
actually be enforced to have a certain mixin instead of a primary)
##########
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java
##########
@@ -1295,6 +1298,33 @@ public void endElement(String uri, String localName,
String qName) throws SAXExc
}
}
+ private boolean hasSiblingWithSameType(Node child) throws
RepositoryException {
+
+ Node parent = child.getParent();
+
+ try {
+ EffectiveNodeType ent = EffectiveNodeType.ofNode(parent);
+ String typeName =
ent.getApplicableChildNodeDefinition(child.getName(),
child.getPrimaryNodeType()).get().getName();
Review comment:
I am not talking about line 6 which takes into account mixins and
inheritance, but about line 7 which retrieves the applicable node type. IMHO
this needs to parameterized with name, primary and mixin types otherwise the
wrong applicable child node definition might be returned (the child node might
actually be enforced to have a certain mixin instead of a primary)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
