anchela commented on pull request #471: URL: https://github.com/apache/jackrabbit-oak/pull/471#issuecomment-1035984133
@enapps-enorman , one more comment regarding > I'm not sure it would be practical to try to automatically add a mixin type during the setProperty calls, as there could be multiple choices on which mixin to use. This is why I prefer to add the mixin to the home node in a custom ActionProvider when the user/group is created. it's perfectly fine if you add the mixin(s) as part of an authorizable-action for your use-case, which apparently only stores properties directly below the user node. however, this improvement should not be limited to your use-case but should work on an general level. instead of trying to add the 'right' mixin I would therefore suggest to add all configured mixin types. we may also consider limiting the configuration option by setting a cardinality (2 or 5) that would prevent the number of mixins added to be unnecessary big. after all one can always leverage supertypes if there is the need for more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
