nit0906 commented on code in PR #490:
URL: https://github.com/apache/jackrabbit-oak/pull/490#discussion_r871489114
##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticConnection.java:
##########
@@ -135,8 +180,11 @@ public boolean isAvailable() {
@Override
public synchronized void close() throws IOException {
- if (client != null) {
- client.close();
+ if (esClient != null) {
+ esClient._transport().close();
Review Comment:
is esAsyncClient also closed as part of this call ? Or should we close that
separately ? Since it's created independently - I would assume it would need to
be closed separately too (but I might be wrong here.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
