nit0906 commented on code in PR #490:
URL: https://github.com/apache/jackrabbit-oak/pull/490#discussion_r871568722
##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticConnection.java:
##########
@@ -108,11 +123,41 @@ public RestHighLevelClient getClient() {
Header[] headers = new Header[]{new
BasicHeader("Authorization", "ApiKey " + apiKeyAuth)};
builder.setDefaultHeaders(headers);
}
- client = new RestHighLevelClient(builder);
+ RestClient httpClient = builder.build();
+ hlClient = new
RestHighLevelClientBuilder(httpClient).setApiCompatibilityMode(true).build();
+
+ ElasticsearchTransport transport = new RestClientTransport(
+ httpClient, new JacksonJsonpMapper());
+ esClient = new ElasticsearchClient(transport);
+ esAsyncClient = new ElasticsearchAsyncClient(transport);
Review Comment:
Could there be a case where esClient could be null but not esAsyncClient ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
