anchela commented on code in PR #590:
URL: https://github.com/apache/jackrabbit-oak/pull/590#discussion_r896866667
##########
oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/basic/DefaultSyncContext.java:
##########
@@ -522,7 +522,7 @@ protected void syncMembership(@NotNull ExternalIdentity
external, @NotNull Autho
while (grpIter.hasNext()) {
Group grp = grpIter.next();
if (isSameIDP(grp)) {
- declaredExternalGroups.put(grp.getID(), grp);
+ declaredExternalGroups.put(grp.getID().toLowerCase(), grp);
Review Comment:
hi @mbaedke , i am not sure i can follow you on this one..... what is the
new group-ids list for? and why would someone get spammed with warnings?
sorry.... i don't get it.
what i had in mind is something along the following lines:
```
Group previous = declaredExternalGroups.put(grp.getID().toLowerCase(), grp);
if (previous != null) {
log.warn("Replacing group '{}' with same case-insensitive name '{}'",
previous.getId(), grp.getID());
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
