mbaedke commented on code in PR #590:
URL: https://github.com/apache/jackrabbit-oak/pull/590#discussion_r897941049
##########
oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/basic/DefaultSyncContext.java:
##########
@@ -522,7 +522,7 @@ protected void syncMembership(@NotNull ExternalIdentity
external, @NotNull Autho
while (grpIter.hasNext()) {
Group grp = grpIter.next();
if (isSameIDP(grp)) {
- declaredExternalGroups.put(grp.getID(), grp);
+ declaredExternalGroups.put(grp.getID().toLowerCase(), grp);
Review Comment:
Hi @anchela, I don't understand. Your code would do nothing, because
declaredExternalGroups is empty initially.
Re spamming: the warnings will stay, because the ids do not change in the
repo or in the LDAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
