AngelaFabregues commented on code in PR #578:
URL: https://github.com/apache/jackrabbit-oak/pull/578#discussion_r901649408
##########
oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneDocumentMaker.java:
##########
@@ -88,7 +88,7 @@ public LuceneDocumentMaker(@Nullable
FulltextBinaryTextExtractor textExtractor,
@Override
protected void indexAnalyzedProperty(Document doc, String pname, String
value, PropertyDefinition pd) {
String analyzedPropName = constructAnalyzedPropertyName(pname);
- doc.add(newPropertyField(analyzedPropName, value,
!pd.skipTokenization(pname), pd.stored));
+ doc.add(newPropertyField(analyzedPropName, value,
!pd.skipTokenization(pname), pd.useInExcerpt));
Review Comment:
The pd.stored is being populated from useInExcerpt JCR property name. The
PropertyDefinition class as a concept represents the JCR properties of a JCR
node which represents an oak index rule property.
stored is not a valid JCR node property for an oak index rule property.
Stored is a Lucene/Elastic internal thing. The class and the methods become
harder to read with stored instead of useInExcerpt.
Also, I think that backward compatibility is provided at oak index rule
property configuration, not at class param (code) level, right? <--- not sure
@fabriziofortino
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
