fabriziofortino commented on code in PR #578:
URL: https://github.com/apache/jackrabbit-oak/pull/578#discussion_r901654675


##########
oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneDocumentMaker.java:
##########
@@ -88,7 +88,7 @@ public LuceneDocumentMaker(@Nullable 
FulltextBinaryTextExtractor textExtractor,
     @Override
     protected void indexAnalyzedProperty(Document doc, String pname, String 
value, PropertyDefinition pd) {
         String analyzedPropName = constructAnalyzedPropertyName(pname);
-        doc.add(newPropertyField(analyzedPropName, value, 
!pd.skipTokenization(pname), pd.stored));
+        doc.add(newPropertyField(analyzedPropName, value, 
!pd.skipTokenization(pname), pd.useInExcerpt));

Review Comment:
   `oak-search`  could be potentially used by an external project as a 
dependency. If you want to change a public member, you have to a) deprecate it 
b) remove it in a successive major release. My suggestion is to use `stored`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to