thomasmueller commented on code in PR #640:
URL: https://github.com/apache/jackrabbit-oak/pull/640#discussion_r932927821
##########
oak-benchmarks-elastic/src/main/java/org/apache/jackrabbit/oak/benchmark/ElasticBenchmarkRunner.java:
##########
@@ -25,7 +25,7 @@ public class ElasticBenchmarkRunner extends BenchmarkRunner {
private static ElasticConnection connection;
- public static void main(String[] args) throws Exception {
+ public static int main(String[] args) throws Exception {
Review Comment:
You can run Java programs with "java ... <className>" but only if they have
public static *void* main method. So this change would have the (unintended?)
consequence that this is no longer possible.
I think public static void main, and then System.exit(code) wouldn't cause
this incompatibility. Are you sue System.exit doesn't work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
