joerghoh commented on code in PR #640:
URL: https://github.com/apache/jackrabbit-oak/pull/640#discussion_r932971309
##########
oak-benchmarks-elastic/src/main/java/org/apache/jackrabbit/oak/benchmark/ElasticBenchmarkRunner.java:
##########
@@ -25,7 +25,7 @@ public class ElasticBenchmarkRunner extends BenchmarkRunner {
private static ElasticConnection connection;
- public static void main(String[] args) throws Exception {
+ public static int main(String[] args) throws Exception {
Review Comment:
```ElasticBenchmarkRunner``` is called from the BenchmarkElasticCommand, and
it does not integrate into ```oak-run```, but nevertheless implements
```Command```.
I agree, you should still have the chance to start the
```ElasticBenchmarkRunner``` as a standalone command, but in that case I would
move the logic out of the ```main``` method into a ```runBenchmark``` method,
which gets the same params as ```main``` but has a return value.
Will post an update to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
