thomasmueller commented on code in PR #646:
URL: https://github.com/apache/jackrabbit-oak/pull/646#discussion_r937444976
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java:
##########
@@ -1411,7 +1411,7 @@ public <T extends Document> void prefetch(Collection<T>
collection,
List<String> resultKeys = new ArrayList<>(keys.size());
CacheChangesTracker tracker = null;
if (collection == Collection.NODES) {
- tracker = nodesCache.registerTracker(keys);
+ tracker = nodesCache.registerTracker(new HashSet<>(keys));
Review Comment:
> it just registers the given keys
Yes, but we had "registerTracker(keys)" before and you changed it to
"registerTracker(new HashSet<>(keys))" and I wanted to understand the reason
for this change
```
- tracker = nodesCache.registerTracker(keys);
+ tracker = nodesCache.registerTracker(new HashSet<>(keys));
```
> I would only sort if there is evidence that it is faster.
Sure.
> Compression over the wire is a connection option
Thanks! So no LZ4, but there's Snappy. (which is a bit slower than LZ4 I
think)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
