thomasmueller commented on code in PR #646:
URL: https://github.com/apache/jackrabbit-oak/pull/646#discussion_r937451455
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java:
##########
@@ -1411,7 +1411,7 @@ public <T extends Document> void prefetch(Collection<T>
collection,
List<String> resultKeys = new ArrayList<>(keys.size());
CacheChangesTracker tracker = null;
if (collection == Collection.NODES) {
- tracker = nodesCache.registerTracker(keys);
+ tracker = nodesCache.registerTracker(new HashSet<>(keys));
Review Comment:
Ah, is it because "Keys collection passed to registerTracker must not be
modified later" and you wanted to ensure the set is not modified later? I
think it's fine... It might make sense to add a comment in the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
