kwin commented on code in PR #279:
URL:
https://github.com/apache/jackrabbit-filevault/pull/279#discussion_r1117264882
##########
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/AbstractExporter.java:
##########
@@ -201,6 +201,8 @@ public void export(VaultFile parent, boolean noClose)
// update properties
setProperty(MetaInf.CREATED, Calendar.getInstance());
setProperty(MetaInf.CREATED_BY, mgr.getUserId());
+ String moduleName = "org.apache.jackrabbit.vault";
+ setProperty(MetaInf.GENERATOR, moduleName + ":" +
getVersion(moduleName, this.getClass()));
Review Comment:
The high-level API (with individual getters) is the preferred way of
accessing package properties rather than using the low-level API (accessing via
key parameter) as
a) it doesn't require to deal with key literals or constants
b) allows for caching or lookup in the manifest alternatively
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
