kwin commented on code in PR #279:
URL:
https://github.com/apache/jackrabbit-filevault/pull/279#discussion_r1125013898
##########
vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/PackageProperties.java:
##########
@@ -239,6 +244,12 @@ public interface PackageProperties {
*/
String getCreatedBy();
+ /**
+ * Returns the name and version of the component that generated the
package.
+ * @return the generator or {@code null} if n/a
Review Comment:
Can you add since tag?
##########
vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageDefinitionImpl.java:
##########
@@ -646,6 +646,13 @@ public String getCreatedBy() {
return get(PN_CREATED_BY);
}
+ /**
+ * {@inheritDoc}
+ */
+ public String getGenerator() {
Review Comment:
Can you add `@Override`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
