reschke commented on code in PR #863:
URL: https://github.com/apache/jackrabbit-oak/pull/863#discussion_r1122710128


##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java:
##########
@@ -1074,6 +1078,10 @@ private <T extends Document> T 
findAndModify(Collection<T> collection,
                 }
             }
 
+            int size = updateOp.toString().length();
+            if(size > SIZE_LIMIT) {

Review Comment:
   ```suggestion
               if (size > SIZE_LIMIT) {
   ```



##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java:
##########
@@ -1074,6 +1078,10 @@ private <T extends Document> T 
findAndModify(Collection<T> collection,
                 }
             }
 
+            int size = updateOp.toString().length();

Review Comment:
   Obtaining the string representation might be expensive, no?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to