reschke commented on code in PR #863:
URL: https://github.com/apache/jackrabbit-oak/pull/863#discussion_r1187204713
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java:
##########
@@ -1470,8 +1487,18 @@ public <T extends Document> boolean create(Collection<T>
collection, List<Update
}
insertSuccess = true;
return true;
- } catch (MongoException e) {
- return false;
+ } catch (BsonMaximumSizeExceededException e) {
+ T doct = null;
+ for (T doc : docs) {
+ doct = doc;
+ // doc.getMemory()/2 - converting from UTF-16 to UTF-8
+ if (doc.getMemory()/2 > SIZE_LIMIT) {
Review Comment:
Well, the character encoding is just one source of differences. BSON is a
binary serialization. What we use is an *estimate* of memory used in the VM.
That is somewhat related, but not directly.
I agree with @mreutegg that just listing the estimated VM size is good
enough (maybe: "document id '...' has estimated size xyz in VM"), and maybe
sort those in descending order (if it's not too much trouble).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
