thomasmueller commented on code in PR #871:
URL: https://github.com/apache/jackrabbit-oak/pull/871#discussion_r1137088754
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/IndexUpdate.java:
##########
@@ -330,9 +334,14 @@ private void collectIndexEditors(NodeBuilder definitions,
// then we don't need to handle missing handler
if (definition.hasProperty(ASYNC_PROPERTY_NAME) &&
rootState.async == null) {
if (!TYPE_DISABLED.equals(type)) {
- log.warn("Missing provider for nrt/sync index: {}
(rootState.async: {}). " +
- "Please note, it means that index data
should be trusted only after this index " +
- "is processed in an async indexing
cycle.", definition, rootState.async);
+ long now = System.currentTimeMillis();
+ if (now > lastMissingProviderMessageTime + 60 *
1000) {
+ lastMissingProviderMessageTime = now;
Review Comment:
It isn't for performance, but for simplicity. In my view, race conditions in
this area (logging) are not a problem: worst case, we would log multiple times;
that is fine. Sure, if there is a way to do this without adding complexity that
would be nice as well! I'll try with AtomicLong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
