nfsantos commented on code in PR #871:
URL: https://github.com/apache/jackrabbit-oak/pull/871#discussion_r1138225969
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/IndexUpdate.java:
##########
@@ -330,9 +334,14 @@ private void collectIndexEditors(NodeBuilder definitions,
// then we don't need to handle missing handler
if (definition.hasProperty(ASYNC_PROPERTY_NAME) &&
rootState.async == null) {
if (!TYPE_DISABLED.equals(type)) {
- log.warn("Missing provider for nrt/sync index: {}
(rootState.async: {}). " +
- "Please note, it means that index data
should be trusted only after this index " +
- "is processed in an async indexing
cycle.", definition, rootState.async);
+ long now = System.currentTimeMillis();
Review Comment:
An alternative that relies in `System.nanoTime()` and is somewhat more
readable is to use the StopWatch class from Guava. Just showing it here as a
reference, not sure if it is worth to use it in this case:
```java
private static volatile Stopwatch lastMissingProviderMessageTime =
Stopwatch.createStarted();
long sinceLastLogMillis =
lastMissingProviderMessageTime.elapsed(TimeUnit.MILLISECONDS);
if (sinceLastLogMillis > 1000) {
lastMissingProviderMessageTime = Stopwatch.createStarted();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
