nfsantos commented on code in PR #871:
URL: https://github.com/apache/jackrabbit-oak/pull/871#discussion_r1138228195
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/IndexUpdate.java:
##########
@@ -330,9 +334,14 @@ private void collectIndexEditors(NodeBuilder definitions,
// then we don't need to handle missing handler
if (definition.hasProperty(ASYNC_PROPERTY_NAME) &&
rootState.async == null) {
if (!TYPE_DISABLED.equals(type)) {
- log.warn("Missing provider for nrt/sync index: {}
(rootState.async: {}). " +
- "Please note, it means that index data
should be trusted only after this index " +
- "is processed in an async indexing
cycle.", definition, rootState.async);
+ long now = System.currentTimeMillis();
+ if (now > lastMissingProviderMessageTime + 60 *
1000) {
+ lastMissingProviderMessageTime = now;
Review Comment:
Ok, I also can't think of a way that ensures that we log only once per
second using atomic variable. But could you just add a comment to say that the
code does not ensure that we log at most once per second but that is ok in this
case? So that our future selves or other people will not look at the code and
be misled by it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
