mreutegg commented on code in PR #920:
URL: https://github.com/apache/jackrabbit-oak/pull/920#discussion_r1205542256
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/ThrottlingStatsCollectorImpl.java:
##########
@@ -126,12 +126,22 @@ public void doneCreateOrUpdate(long throttlingTimeNanos,
Collection<? extends Do
public void doneFindAndModify(long throttlingTimeNanos, Collection<?
extends Document> collection, String key, boolean newEntry,
boolean success, int retryCount) {
- modifyMetricUpdater.update(collection, retryCount,
throttlingTimeNanos, success, newEntry, c -> c == NODES,
+ modifyMetricUpdater.update(collection, retryCount,
throttlingTimeNanos, success, newEntry, of(key), isNodesCollectionUpdated(),
getStatsConsumer(), getStatsConsumer(), MeterStats::mark,
MeterStats::mark);
perfLog(perfLog, PERF_LOG_THRESHOLD, throttlingTimeNanos,
"findAndModify [{}]", key);
}
+ @Override
+ public void doneFindAndModify(long throttlingTimeNanos, Collection<?
extends Document> collection, List<String> ids, boolean newEntry,
+ boolean success, int retryCount) {
+
+ modifyMetricUpdater.update(collection, retryCount,
throttlingTimeNanos, success, newEntry, ids, isNodesCollectionUpdated(),
+ getStatsConsumer(), getStatsConsumer(), MeterStats::mark,
MeterStats::mark);
+
+ perfLog(perfLog, PERF_LOG_THRESHOLD, throttlingTimeNanos,
"findAndModify [{}]", ids);
Review Comment:
Remove square brackets?
```suggestion
perfLog(perfLog, PERF_LOG_THRESHOLD, throttlingTimeNanos,
"findAndModify {}", ids);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
