mreutegg commented on code in PR #920:
URL: https://github.com/apache/jackrabbit-oak/pull/920#discussion_r1206773049
##########
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/MongoDocumentStoreIT.java:
##########
@@ -268,4 +277,109 @@ public void queryWithNullProjection() {
docs.forEach(d -> assertEquals(4 , d.keySet().size()));
assertEquals(10, docs.size());
}
+
+ // OAK-10213
+ @Test
+ public void findAndUpdateBulk() {
+ DocumentStore docStore = mk.getDocumentStore();
+ DocumentNodeStore store =
builderProvider.newBuilder().setAsyncDelay(0).getNodeStore();
+ Revision rev = Revision.newRevision(0);
+ List<UpdateOp> inserts = new ArrayList<UpdateOp>();
+ for (int i = 0; i < 10; i++) {
+ DocumentNodeState n = new DocumentNodeState(store,
fromString("/node-" + i),
+ new RevisionVector(rev), of(new LongPropertyState("prop",
10L)), false, null);
+ inserts.add(n.asOperation(rev));
+ }
+ docStore.create(Collection.NODES, inserts);
+
+ List<UpdateOp> updateOps = new ArrayList<>(10);
+ for (int i = 0; i < 10; i++) {
+ UpdateOp updateOp = new UpdateOp(getIdFromPath(fromString("/node-"
+ i)), false);
+ updateOp.set("prop", 20L);
+ updateOp.contains("prop", true);
+ updateOps.add(updateOp);
+ }
+
+ List<NodeDocument> docs = docStore.findAndUpdate(NODES, updateOps);
+ assertEquals(10, docs.size());
+ docs.forEach(doc -> assertTrue(doc.isSealed()));
+ docs.forEach(d -> assertEquals(10L,
parseLong(d.getLocalMap("prop").get(d.getLocalMap("prop").firstKey()))));
+ }
+
+ @Test
+ public void findAndUpdateBulkNotFound() {
+ DocumentStore docStore = mk.getDocumentStore();
+ DocumentNodeStore store =
builderProvider.newBuilder().setAsyncDelay(0).getNodeStore();
+ Revision rev = Revision.newRevision(0);
+ List<UpdateOp> inserts = new ArrayList<UpdateOp>();
+ for (int i = 0; i < 10; i++) {
+ DocumentNodeState n = new DocumentNodeState(store,
fromString("/node-" + i),
+ new RevisionVector(rev), of(new LongPropertyState("prop",
10L)), false, null);
+ inserts.add(n.asOperation(rev));
+ }
+ docStore.create(Collection.NODES, inserts);
+
+ List<UpdateOp> updateOps = new ArrayList<>(10);
+ for (int i = 0; i < 10; i++) {
+ UpdateOp updateOp = new UpdateOp(getIdFromPath(fromString("/node-"
+ i)), false);
+ updateOp.set("prop", 20L);
+ updateOp.contains("prop", false);
+ updateOps.add(updateOp);
+ }
+
+ List<NodeDocument> docs = docStore.findAndUpdate(NODES, updateOps);
+ assertEquals(10, docs.size());
+ docs.forEach(Assert::assertNull);
+ }
+
+ @Test
+ public void findAndUpdateBulkNotAllFound() {
+ DocumentStore docStore = mk.getDocumentStore();
+ DocumentNodeStore store =
builderProvider.newBuilder().setAsyncDelay(0).getNodeStore();
+ Revision rev = Revision.newRevision(0);
+ List<UpdateOp> inserts = new ArrayList<UpdateOp>();
+ for (int i = 0; i < 10; i++) {
+ DocumentNodeState n = new DocumentNodeState(store,
fromString("/node-" + i),
+ new RevisionVector(rev), of(new LongPropertyState("prop",
10L)), false, null);
+ inserts.add(n.asOperation(rev));
+
+ n = new DocumentNodeState(store, fromString("/node-" + (i+100)),
+ new RevisionVector(rev), of(new LongPropertyState("prop2",
10L)), false, null);
+ inserts.add(n.asOperation(rev));
+
+ }
+ docStore.create(Collection.NODES, inserts);
+
+ List<UpdateOp> updateOps = new ArrayList<>(20);
+ for (int i = 0; i < 10; i++) {
+ UpdateOp updateOp = new UpdateOp(getIdFromPath(fromString("/node-"
+ i)), false);
+ updateOp.set("prop", 20L);
+ updateOp.contains("prop", false);
+ updateOps.add(updateOp);
+
+ updateOp = new UpdateOp(getIdFromPath(fromString("/node-" +
(i+100))), false);
+ updateOp.set("prop2", 20L);
+ updateOp.contains("prop", false);
+ updateOps.add(updateOp);
+ }
Review Comment:
Similar to previous comment. Can you please update accordingly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
