stefan-egli commented on code in PR #962:
URL: https://github.com/apache/jackrabbit-oak/pull/962#discussion_r1218089731
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/Oak.java:
##########
@@ -801,7 +802,8 @@ private ContentRepository createNewContentRepository() {
queryEngineSettings.unwrap(),
indexProvider,
securityProvider,
- new AggregatingDescriptors(t)) {
+ new AggregatingDescriptors(t),
+ newFeature("OAK-10147", whiteboard)) {
Review Comment:
elsewhere we used a slightly different naming convention (eg
"FT_PREFETCH_OAK-9780"). Is this here the final name?
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/core/MutableRoot.java:
##########
@@ -403,7 +412,31 @@ public PermissionProvider getPermissionProvider() {
* Moves can be applied to {@code MutableTree} instances by calling {@code
apply()},
* which will execute all moves in the list on the passed tree instance
*/
- class Move {
+ interface Move {
+
+ /**
+ * Set this move to the given source and destination. Creates a new
empty
+ * slot, sets this as the next move and returns it.
+ */
+ Move setMove(String source, MutableTree destParent, String destName);
+
+ /**
+ * Apply this and all subsequent moves to the passed tree instance.
+ */
+ Move apply(MutableTree tree);
+ }
+
+ Move createMove(@Nullable Feature classicMove) {
+ // default implementation is memory reduced move, unless classic
+ // implementation is enabled by system property or feature toggle
+ if (CLASSIC_MOVE || (classicMove != null && classicMove.isEnabled())) {
+ return new ClassicMove();
Review Comment:
IIUC then this is unlike previously where we introduced new features
`disabled` first. Here it would be `enabled` by default and only `disabled`
depending on an active property/toggle. I'm wondering as to why this was was
chosen versus the one we did previously?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
